+1 (binding) https://github.com/apache/kafka/pull/132/files#diff-5d4a4a97554d3ac24efe68d98eb27b64L63 I like the CLI implementation and general purpose of it, looks like a great way to set attribute/strings on brokers and some more stuff to-do I think before this hits trunk but overall we should work on shipping this. Left some other comments on the PR sorry if I missed the entire [discuss] thread on this.
~ Joe Stein On Sun, Jan 10, 2016 at 9:31 PM, Stevo Slavić <ssla...@gmail.com> wrote: > +1 (non-binding) > > On Tue, Jan 5, 2016 at 1:30 AM, Allen Wang <allenxw...@gmail.com> wrote: > > > I would like to call for a vote for KIP-36 - Rack aware replica > assignment. > > > > The latest proposal is at > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-36 > > +Rack+aware+replica+assignment > > > > Thanks, > > Allen > > >