[ 
https://issues.apache.org/jira/browse/KAFKA-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15083117#comment-15083117
 ] 

ASF GitHub Bot commented on KAFKA-2934:
---------------------------------------

GitHub user ZoneMayor opened a pull request:

    https://github.com/apache/kafka/pull/734

    KAFKA-2934: Offset storage file configuration in Connect standalone mode is 
not included in StandaloneConfig

    Added offsetBackingStore config to StandaloneConfig and DistributedConfig;
    Added config for offset.storage.topic and config.storage.topic into 
DistributedConfig;

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ZoneMayor/kafka trunk-KAFKA-2934

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/734.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #734
    
----
commit 34240b52e1b70aa172b65155f6042243d838b420
Author: ZoneMayor <jinxing6...@126.com>
Date:   2015-12-18T07:22:20Z

    Merge pull request #12 from apache/trunk
    
    2015-12-18

commit 52d02f333e86d06cfa8fff5facd18999b3db6d83
Author: ZoneMayor <jinxing6...@126.com>
Date:   2015-12-30T03:08:08Z

    Merge pull request #13 from apache/trunk
    
    2015-12-30

commit dd90fb07a073de2f58ba6d868348aeaf9e70a6a3
Author: jinxing <jinx...@fenbi.com>
Date:   2016-01-02T12:49:18Z

    KAFKA-2934: Offset storage file configuration in Connect standalone mode is 
not included in StandaloneConfig

commit ff572f805de3eb7de94046f6e29aee7254262d4c
Author: jinxing <jinx...@fenbi.com>
Date:   2016-01-02T14:21:19Z

    fix

----


> Offset storage file configuration in Connect standalone mode is not included 
> in StandaloneConfig
> ------------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-2934
>                 URL: https://issues.apache.org/jira/browse/KAFKA-2934
>             Project: Kafka
>          Issue Type: Bug
>          Components: copycat
>    Affects Versions: 0.9.0.0
>            Reporter: Ewen Cheslack-Postava
>            Assignee: Ewen Cheslack-Postava
>
> The config is coded directly in FileOffsetBackingStore rather than being 
> listed (and validated) in StandaloneConfig. This also means it wouldn't be 
> included if we autogenerated docs from the config classes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to