[
https://issues.apache.org/jira/browse/KAFKA-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15155924#comment-15155924
]
ASF GitHub Bot commented on KAFKA-2934:
---------------------------------------
GitHub user ZoneMayor reopened a pull request:
https://github.com/apache/kafka/pull/734
KAFKA-2934: Offset storage file configuration in Connect standalone mode is
not included in StandaloneConfig
Added offsetBackingStore config to StandaloneConfig and DistributedConfig;
Added config for offset.storage.topic and config.storage.topic into
DistributedConfig;
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ZoneMayor/kafka trunk-KAFKA-2934
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/734.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #734
----
commit 34240b52e1b70aa172b65155f6042243d838b420
Author: ZoneMayor <jinxing6...@126.com>
Date: 2015-12-18T07:22:20Z
Merge pull request #12 from apache/trunk
2015-12-18
commit 52d02f333e86d06cfa8fff5facd18999b3db6d83
Author: ZoneMayor <jinxing6...@126.com>
Date: 2015-12-30T03:08:08Z
Merge pull request #13 from apache/trunk
2015-12-30
commit dd90fb07a073de2f58ba6d868348aeaf9e70a6a3
Author: jinxing <jinx...@fenbi.com>
Date: 2016-01-02T12:49:18Z
KAFKA-2934: Offset storage file configuration in Connect standalone mode is
not included in StandaloneConfig
commit ff572f805de3eb7de94046f6e29aee7254262d4c
Author: jinxing <jinx...@fenbi.com>
Date: 2016-01-02T14:21:19Z
fix
commit 394a1ab9e757d70d2cb83c70afcfbc5c13ca08a1
Author: jinxing <jinx...@fenbi.com>
Date: 2016-01-10T08:43:58Z
Revert "fix"
This reverts commit ff572f805de3eb7de94046f6e29aee7254262d4c.
commit 1eff43becd670add7e437dec3e2f34cb384b4ccf
Author: jinxing <jinx...@fenbi.com>
Date: 2016-01-10T08:44:10Z
Revert "KAFKA-2934: Offset storage file configuration in Connect standalone
mode is not included in StandaloneConfig"
This reverts commit dd90fb07a073de2f58ba6d868348aeaf9e70a6a3.
commit 133cb430c091957dc721bc9295dccbb98774b24c
Author: jinxing <jinx...@fenbi.com>
Date: 2016-01-10T09:09:21Z
KAFKA-2934: Offset storage file configuration in Connect standalone mode is
not included in StandaloneConfig
commit d56be0b9e0849660c07d656c6019f9cc2f17ae55
Author: ZoneMayor <jinxing6...@126.com>
Date: 2016-01-10T09:24:06Z
Merge pull request #14 from apache/trunk
2016-1-10
commit bbebd13d46930f875aac1d86f663c30daa8a9b28
Author: jinxing <jinx...@fenbi.com>
Date: 2016-01-12T02:48:54Z
Merge branch 'trunk-KAFKA-2934' of https://github.com/ZoneMayor/kafka into
trunk-KAFKA-2934
commit 5e0ba3b306afb871bf5de1f95ec47cec2874a5a0
Author: jinxing <jinx...@fenbi.com>
Date: 2016-01-12T03:41:51Z
fix and add default value for offset.storage.file.filename,
offset.storage.topic, config.storage.topic
commit fbd380659727d991dff242be33cc6a3bb78f4861
Author: ZoneMayor <jinxing6...@126.com>
Date: 2016-01-28T06:28:25Z
Merge pull request #15 from apache/trunk
2016-01-28
commit 16d9990ff999ec900a041b501b0eb9d5a5a02810
Author: ZoneMayor <jinxing6...@126.com>
Date: 2016-02-16T13:40:59Z
Merge pull request #16 from apache/trunk
2016-02-16
commit cc6819942012174940fd8c2a79acccb6d3e05282
Author: ZoneMayor <jinxing6...@126.com>
Date: 2016-02-18T08:42:48Z
Merge pull request #17 from apache/trunk
2016-02-18
commit 76dc053011a99efdeba4b750dd20d3381e4af980
Author: jinxing <jinx...@fenbi.com>
Date: 2016-02-18T08:55:25Z
Merge branch 'trunk-KAFKA-2934' of https://github.com/ZoneMayor/kafka into
trunk-KAFKA-2934
commit 7c1413f29c9b3c95cffab7f60aa23972dada4bd7
Author: jinxing <jinx...@fenbi.com>
Date: 2016-02-18T13:02:44Z
KAFKA-2934: fix
commit a222d4fdded70355edbcda9d48ded12a1085461f
Author: jinxing <jinx...@fenbi.com>
Date: 2016-02-18T14:05:03Z
fix test
commit 7ed1551469c86cfdd211b28d49dea95c7f85684a
Author: jinxing <jinxing6...@126.com>
Date: 2016-02-18T14:08:03Z
fix
----
> Offset storage file configuration in Connect standalone mode is not included
> in StandaloneConfig
> ------------------------------------------------------------------------------------------------
>
> Key: KAFKA-2934
> URL: https://issues.apache.org/jira/browse/KAFKA-2934
> Project: Kafka
> Issue Type: Bug
> Components: copycat
> Affects Versions: 0.9.0.0
> Reporter: Ewen Cheslack-Postava
> Assignee: Ewen Cheslack-Postava
>
> The config is coded directly in FileOffsetBackingStore rather than being
> listed (and validated) in StandaloneConfig. This also means it wouldn't be
> included if we autogenerated docs from the config classes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
