[ 
https://issues.apache.org/jira/browse/KAFKA-2648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14975482#comment-14975482
 ] 

Jason Gustafson commented on KAFKA-2648:
----------------------------------------

[~guozhang] I would actually prefer checking this on the server side, and I 
agree that it would be nice to not have to set groupId in cases where you don't 
actually need it. The only concern I had was whether there were any existing 
applications that depended on being able to use empty groupId for offset 
commits. 

> Coordinator should not allow empty groupIds
> -------------------------------------------
>
>                 Key: KAFKA-2648
>                 URL: https://issues.apache.org/jira/browse/KAFKA-2648
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.9.0.0
>            Reporter: Jason Gustafson
>            Assignee: Jason Gustafson
>
> The coordinator currently allows consumer groups with empty groupIds, but 
> there probably aren't any cases where this is actually a good idea and it 
> tends to mask problems where different groups have simply not configured a 
> groupId. To address this, we can add a new error code, say INVALID_GROUP_ID, 
> which the coordinator can return when it encounters an  empty groupID. We 
> should also make groupId a required property in consumer configuration and 
> enforce that it is non-empty. 
> It's a little unclear whether this change would have compatibility concerns. 
> The old consumer will fail with an empty groupId (because it cannot create 
> the zookeeper paths), but other clients may allow it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to