[
https://issues.apache.org/jira/browse/KAFKA-2648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14974878#comment-14974878
]
ASF GitHub Bot commented on KAFKA-2648:
---------------------------------------
GitHub user hachikuji opened a pull request:
https://github.com/apache/kafka/pull/362
KAFKA-2648: group.id is required for new consumer and cannot be empty
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hachikuji/kafka KAFKA-2648
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/362.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #362
----
commit 5a419664f36fcbb955e250ebfe8c531e50fff981
Author: Jason Gustafson <ja...@confluent.io>
Date: 2015-10-26T19:40:02Z
KAFKA-2648: group.id is required for new consumer and cannot be empty
----
> Coordinator should not allow empty groupIds
> -------------------------------------------
>
> Key: KAFKA-2648
> URL: https://issues.apache.org/jira/browse/KAFKA-2648
> Project: Kafka
> Issue Type: Bug
> Affects Versions: 0.9.0.0
> Reporter: Jason Gustafson
> Assignee: Jason Gustafson
>
> The coordinator currently allows consumer groups with empty groupIds, but
> there probably aren't any cases where this is actually a good idea and it
> tends to mask problems where different groups have simply not configured a
> groupId. To address this, we can add a new error code, say INVALID_GROUP_ID,
> which the coordinator can return when it encounters an empty groupID. We
> should also make groupId a required property in consumer configuration and
> enforce that it is non-empty.
> It's a little unclear whether this change would have compatibility concerns.
> The old consumer will fail with an empty groupId (because it cannot create
> the zookeeper paths), but other clients may allow it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
