[ 
https://issues.apache.org/jira/browse/KAFKA-2474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14945936#comment-14945936
 ] 

ASF GitHub Bot commented on KAFKA-2474:
---------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/kafka/pull/250


> Add caching for converted Copycat schemas in JSONConverter
> ----------------------------------------------------------
>
>                 Key: KAFKA-2474
>                 URL: https://issues.apache.org/jira/browse/KAFKA-2474
>             Project: Kafka
>          Issue Type: Sub-task
>          Components: copycat
>            Reporter: Ewen Cheslack-Postava
>            Assignee: Ewen Cheslack-Postava
>             Fix For: 0.9.0.0
>
>
> From discussion of KAFKA-2367:
> bq. Caching of conversion of schemas. In the JSON implementation we're 
> including, we're probably being pretty wasteful right now since every record 
> has to translate both the schema and data to JSON. We should definitely be 
> doing some caching here. I think an LRU using an IdentityHashMap should be 
> fine. However, this does assume that connectors are good about reusing 
> schemas (defining them up front, or if they are dynamic they should have 
> their own cache of schemas and be able to detect when they can be reused).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to