[
https://issues.apache.org/jira/browse/KAFKA-2474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14910109#comment-14910109
]
ASF GitHub Bot commented on KAFKA-2474:
---------------------------------------
GitHub user ewencp opened a pull request:
https://github.com/apache/kafka/pull/250
KAFKA-2474: Add caching of JSON schema conversions to JsonConverter.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ewencp/kafka
kafka-2474-cache-json-schema-conversions
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/250.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #250
----
commit b828c60ee1905c8b98ffef1bc48a429439be09fd
Author: Ewen Cheslack-Postava <m...@ewencp.org>
Date: 2015-09-27T23:28:00Z
KAFKA-2474: Add caching of JSON schema conversions to JsonConverter.
----
> Add caching for converted Copycat schemas in JSONConverter
> ----------------------------------------------------------
>
> Key: KAFKA-2474
> URL: https://issues.apache.org/jira/browse/KAFKA-2474
> Project: Kafka
> Issue Type: Sub-task
> Components: copycat
> Reporter: Ewen Cheslack-Postava
> Assignee: Ewen Cheslack-Postava
> Fix For: 0.9.0.0
>
>
> From discussion of KAFKA-2367:
> bq. Caching of conversion of schemas. In the JSON implementation we're
> including, we're probably being pretty wasteful right now since every record
> has to translate both the schema and data to JSON. We should definitely be
> doing some caching here. I think an LRU using an IdentityHashMap should be
> fine. However, this does assume that connectors are good about reusing
> schemas (defining them up front, or if they are dynamic they should have
> their own cache of schemas and be able to detect when they can be reused).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
