[ https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14660397#comment-14660397 ]
Mayuresh Gharat commented on KAFKA-2120: ---------------------------------------- [~becket_qin] yes we can do that. I will create a separate ticket and work on that. I think we should not include that in this patch if possible since this patch is specifically for KIP-19. Let us wait a bit and think on this a bit and then I will send out the jira links for the new tickets. Thanks, Mayuresh > Add a request timeout to NetworkClient > -------------------------------------- > > Key: KAFKA-2120 > URL: https://issues.apache.org/jira/browse/KAFKA-2120 > Project: Kafka > Issue Type: New Feature > Reporter: Jiangjie Qin > Assignee: Mayuresh Gharat > Fix For: 0.8.3 > > Attachments: KAFKA-2120.patch, KAFKA-2120_2015-07-27_15:31:19.patch, > KAFKA-2120_2015-07-29_15:57:02.patch > > > Currently NetworkClient does not have a timeout setting for requests. So if > no response is received for a request due to reasons such as broker is down, > the request will never be completed. > Request timeout will also be used as implicit timeout for some methods such > as KafkaProducer.flush() and kafkaProducer.close(). > KIP-19 is created for this public interface change. > https://cwiki.apache.org/confluence/display/KAFKA/KIP-19+-+Add+a+request+timeout+to+NetworkClient -- This message was sent by Atlassian JIRA (v6.3.4#6332)