[ https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14660303#comment-14660303 ]
Jason Gustafson commented on KAFKA-2120: ---------------------------------------- [~mgharat] Yeah, that's what I mean. I think the consumer has three different cases where a different timeout should be used: 1. Join group requests: The timeout should be based on the session timeout. 2. Fetch requests: The timeout should be based on the fetch max wait time. 3. All others: This includes heartbeats and metadata requests, and can use the default "request.timeout.ms" from this patch. So we don't actually need any new configuration, but it seems like we need to ability to set timeouts differently depending on the request type. > Add a request timeout to NetworkClient > -------------------------------------- > > Key: KAFKA-2120 > URL: https://issues.apache.org/jira/browse/KAFKA-2120 > Project: Kafka > Issue Type: New Feature > Reporter: Jiangjie Qin > Assignee: Mayuresh Gharat > Fix For: 0.8.3 > > Attachments: KAFKA-2120.patch, KAFKA-2120_2015-07-27_15:31:19.patch, > KAFKA-2120_2015-07-29_15:57:02.patch > > > Currently NetworkClient does not have a timeout setting for requests. So if > no response is received for a request due to reasons such as broker is down, > the request will never be completed. > Request timeout will also be used as implicit timeout for some methods such > as KafkaProducer.flush() and kafkaProducer.close(). > KIP-19 is created for this public interface change. > https://cwiki.apache.org/confluence/display/KAFKA/KIP-19+-+Add+a+request+timeout+to+NetworkClient -- This message was sent by Atlassian JIRA (v6.3.4#6332)