[ https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14649515#comment-14649515 ]
Sriharsha Chintalapani commented on KAFKA-1690: ----------------------------------------------- [~ijuma] what you mean by "I think we need to figure out how we are going to proceed with this. " . This patch reviewed by [~junrao] [~jjkoshy] [~mherstine] . I've addressed almost all of the issues asked in the review. I saw your reviews and [~lindong] there are few important things in them and others are style based issue. If we keep adding more reviewers who doesn't have history of the patch and context and I've to keep addressing new reviews this patch will never make it. I am not sure whats your concern is here ?. I don't think there are many issues opened as you suggesting here. I'll address the remaining issues I don't think small style changes needs to block big patch like this. [~junrao] [~jjkoshy] [~mherstine] please go ahead close or comment on the issues you are opened. I think its causing unnecessary confusion. > new java producer needs ssl support as a client > ----------------------------------------------- > > Key: KAFKA-1690 > URL: https://issues.apache.org/jira/browse/KAFKA-1690 > Project: Kafka > Issue Type: Sub-task > Reporter: Joe Stein > Assignee: Sriharsha Chintalapani > Fix For: 0.8.3 > > Attachments: KAFKA-1690.patch, KAFKA-1690.patch, > KAFKA-1690_2015-05-10_23:20:30.patch, KAFKA-1690_2015-05-10_23:31:42.patch, > KAFKA-1690_2015-05-11_16:09:36.patch, KAFKA-1690_2015-05-12_16:20:08.patch, > KAFKA-1690_2015-05-15_07:18:21.patch, KAFKA-1690_2015-05-20_14:54:35.patch, > KAFKA-1690_2015-05-21_10:37:08.patch, KAFKA-1690_2015-06-03_18:52:29.patch, > KAFKA-1690_2015-06-23_13:18:20.patch, KAFKA-1690_2015-07-20_06:10:42.patch, > KAFKA-1690_2015-07-20_11:59:57.patch, KAFKA-1690_2015-07-25_12:10:55.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)