> On July 6, 2015, 9:47 p.m., Jun Rao wrote: > > Thanks for the patch. A few more minor comments blow.
Thanks for the review again Jun! > On July 6, 2015, 9:47 p.m., Jun Rao wrote: > > core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala, line 147 > > <https://reviews.apache.org/r/36030/diff/5/?file=996624#file996624line147> > > > > This can be private, right? It should be. Thanks for pointing out. > On July 6, 2015, 9:47 p.m., Jun Rao wrote: > > core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala, lines > > 148-156 > > <https://reviews.apache.org/r/36030/diff/5/?file=996624#file996624line148> > > > > This seems redundant given the code in 155 to 163. We can probaby just > > assert the broker size on topicMetadata after line 152. True - Ashish ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36030/#review90579 ----------------------------------------------------------- On July 7, 2015, 6:07 a.m., Ashish Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36030/ > ----------------------------------------------------------- > > (Updated July 7, 2015, 6:07 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-972 > https://issues.apache.org/jira/browse/KAFKA-972 > > > Repository: kafka > > > Description > ------- > > KAFKA-972: MetadataRequest returns stale list of brokers > > > Diffs > ----- > > core/src/main/scala/kafka/controller/KafkaController.scala > 36350579b16027359d237b64699003358704ac6f > core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala > 995b05901491bb0dbf0df210d44bd1d7f66fdc82 > > Diff: https://reviews.apache.org/r/36030/diff/ > > > Testing > ------- > > > Thanks, > > Ashish Singh > >
