> On July 1, 2015, 4:37 a.m., Jun Rao wrote: > > core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala, line 69 > > <https://reviews.apache.org/r/36030/diff/2/?file=996282#file996282line69> > > > > Do we need this? In tearDown(), ZookeeperTestHarness will delete all ZK > > data.
Ahh.. I thought its called after all tests in the class are done. Thanks for pointing this out. Removed. > On July 1, 2015, 4:37 a.m., Jun Rao wrote: > > core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala, lines > > 157-161 > > <https://reviews.apache.org/r/36030/diff/2/?file=996282#file996282line157> > > > > Could we issue TopicMetadataRequest to every broker and make sure that > > the correct metadata is propagated to every broker? Ditto in other places > > as well. Done! - Ashish ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36030/#review90005 ----------------------------------------------------------- On July 1, 2015, 8:37 a.m., Ashish Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36030/ > ----------------------------------------------------------- > > (Updated July 1, 2015, 8:37 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-972 > https://issues.apache.org/jira/browse/KAFKA-972 > > > Repository: kafka > > > Description > ------- > > KAFKA-972: MetadataRequest returns stale list of brokers > > > Diffs > ----- > > core/src/main/scala/kafka/controller/KafkaController.scala > 36350579b16027359d237b64699003358704ac6f > core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala > 995b05901491bb0dbf0df210d44bd1d7f66fdc82 > > Diff: https://reviews.apache.org/r/36030/diff/ > > > Testing > ------- > > > Thanks, > > Ashish Singh > >
