[ https://issues.apache.org/jira/browse/KAFKA-2035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14496673#comment-14496673 ]
Jay Kreps commented on KAFKA-2035: ---------------------------------- Fair point. If we are going to model topics though let's make sure we do a really good job of it as that is a a fairly fundamental change to the domain model. E.g. should we have a Topic object which has the set of associated Log instances as well as the topic-specific config...i.e. let's really try to make them a first class entity, maybe a TopicManager if that helps. I feel like adding a TopicConfigCache to KafkaApis is sort of an unhappy midpoint between not modeling topics and modeling them fully. Not sure if that makes any sense? > Add a topic config cache. > ------------------------- > > Key: KAFKA-2035 > URL: https://issues.apache.org/jira/browse/KAFKA-2035 > Project: Kafka > Issue Type: Task > Reporter: Parth Brahmbhatt > Assignee: Parth Brahmbhatt > Attachments: KAFKA-2035_2015-03-31_10:52:12.patch > > > Currently the topic config is all about Log configuration so we have a > TopicConfigManager which takes in a Log instance and keeps updating that > instance's config instance as and when the topic config is updated. The topic > config update notifications are sent using zk watchers by Controller. > I propose to introduce a TopicConfigCache which will be updated by > TopicConfigManager on any config changes. The log instance and any other > component (like the authorizer mentioned in KAFKA-1688) will have a reference > to TopicConfigCache using which they will access the topic configs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)