[ https://issues.apache.org/jira/browse/KAFKA-2035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14389471#comment-14389471 ]
Parth Brahmbhatt commented on KAFKA-2035: ----------------------------------------- As stated in description, the current TopicConfig is only about LogConfig which is why Log.config makes sense. We plan to add Topic acls and Topic owner as part of TopicConfig. With added entities I think it makes more sense to decouple to the LogEntity from the TopicConfig entiry and add a class like the following: class TopicConfig(val owner: String,val logConfig: LogConfig,val acls: Set[Acl], val overrideProperties: Properties) This is essentially the first step for moving in that direction. > Add a topic config cache. > ------------------------- > > Key: KAFKA-2035 > URL: https://issues.apache.org/jira/browse/KAFKA-2035 > Project: Kafka > Issue Type: Task > Reporter: Parth Brahmbhatt > Assignee: Parth Brahmbhatt > Attachments: KAFKA-2035_2015-03-31_10:52:12.patch > > > Currently the topic config is all about Log configuration so we have a > TopicConfigManager which takes in a Log instance and keeps updating that > instance's config instance as and when the topic config is updated. The topic > config update notifications are sent using zk watchers by Controller. > I propose to introduce a TopicConfigCache which will be updated by > TopicConfigManager on any config changes. The log instance and any other > component (like the authorizer mentioned in KAFKA-1688) will have a reference > to TopicConfigCache using which they will access the topic configs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)