> On March 31, 2015, 11:47 p.m., Jun Rao wrote: > > core/src/test/scala/other/kafka/TestPurgatoryPerformance.scala, line 261 > > <https://reviews.apache.org/r/31893/diff/5/?file=900766#file900766line261> > > > > Could we just put FakeOperation to the delayQueue directly instead of > > wrapping it under Scheduled?
We have to use completion time instead of expiration time for CompletionQueue. That is why the operaion is wrapped. - Yasuhiro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31893/#review76975 ----------------------------------------------------------- On April 1, 2015, 12:31 a.m., Yasuhiro Matsuda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31893/ > ----------------------------------------------------------- > > (Updated April 1, 2015, 12:31 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2013 > https://issues.apache.org/jira/browse/KAFKA-2013 > > > Repository: kafka > > > Description > ------- > > purgatory micro benchmark > > > Diffs > ----- > > core/src/test/scala/other/kafka/TestPurgatoryPerformance.scala PRE-CREATION > > Diff: https://reviews.apache.org/r/31893/diff/ > > > Testing > ------- > > > Thanks, > > Yasuhiro Matsuda > >
