----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32650/#review78337 -----------------------------------------------------------
This might be out of scope for this JIRA, but I think if the deleted topic gets recreated before compaction, the offsets corresponding to the older version of the topic won't be deleted. This usually doesn't matter because auto.offset.reset will be triggered if the new version of the topic is smaller than the old version in terms of offsets. As with delete topic from zookeeper-based offsets, there's the edge case of the consumer skipping messages from the new version of the topic if old version's offsets still fit. This edge case was briefly discussed here: https://issues.apache.org/jira/browse/KAFKA-1787 - Onur Karaman On March 30, 2015, 9:47 p.m., Sriharsha Chintalapani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32650/ > ----------------------------------------------------------- > > (Updated March 30, 2015, 9:47 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2000 > https://issues.apache.org/jira/browse/KAFKA-2000 > > > Repository: kafka > > > Description > ------- > > KAFKA-2000. Delete consumer offsets from kafka once the topic is deleted. > > > Diffs > ----- > > core/src/main/scala/kafka/server/OffsetManager.scala > 395b1dbe43a5db47151e72a1b588d72f03cef963 > > Diff: https://reviews.apache.org/r/32650/diff/ > > > Testing > ------- > > > Thanks, > > Sriharsha Chintalapani > >
