----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32650/#review82775 -----------------------------------------------------------
Thanks for the updated patch. core/src/main/scala/kafka/server/OffsetManager.scala <https://reviews.apache.org/r/32650/#comment133593> Sorry I didn't notice this earlier. This message is now slightly incorrect. Can we get a break-up of the number of offsets deleted due to expiration and due to topic deletion? BTW I'm touching this in KAFKA-2163 as well (which you may want to check out). core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala <https://reviews.apache.org/r/32650/#comment133586> Pre-existing issue, but could you rename this to OffsetManagementTest? core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala <https://reviews.apache.org/r/32650/#comment133587> testOffsetsDeletedAfterTopicDeletion core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala <https://reviews.apache.org/r/32650/#comment133588> Can you use the more recent commit version (which has an explicit retention time?) core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala <https://reviews.apache.org/r/32650/#comment133590> Can you also commit offsets for some other topic and verify that those offsets are _not_ deleted? As mentioned in the earlier RB, for the first scenario, we depend on the condition that the UpdateMetadataRequest is sent first. It would be good to have a unit test that explicitly tests this so we never unknowingly break that assumption. I don't have a good way to test this though :( If you have any ideas that would be great. Part of the issue is we have little to no test coverage on the controller. - Joel Koshy On May 3, 2015, 5:39 p.m., Sriharsha Chintalapani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32650/ > ----------------------------------------------------------- > > (Updated May 3, 2015, 5:39 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2000 > https://issues.apache.org/jira/browse/KAFKA-2000 > > > Repository: kafka > > > Description > ------- > > KAFKA-2000. Delete consumer offsets from kafka once the topic is deleted. > > > Diffs > ----- > > core/src/main/scala/kafka/server/OffsetManager.scala > 18680ce100f10035175cc0263ba7787ab0f6a17a > core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala > 652208a70f66045b854549d93cbbc2b77c24b10b > > Diff: https://reviews.apache.org/r/32650/diff/ > > > Testing > ------- > > > Thanks, > > Sriharsha Chintalapani > >
