Yes, I was talking about TopicMetadataRequest.scala (TMR), which is MetadataRequest in java definitions.
None of the mentioned above messages (StopReplica etc) are required in KIP-4. Sorry, if I misled someone. Thanks, Andrii Biletskyi On Wed, Mar 18, 2015 at 5:42 PM, Gwen Shapira <gshap...@cloudera.com> wrote: > Sorry, Andrii, I'm a bit confused. > > The following request/response pairs are currently not implemented in > the client: > StopReplica, LeaderAndIsr, UpdateMetadata, ControlledShutdown. > > Does KIP-4 require any of these? > > Also, what's TMR? > > Gwen > > On Wed, Mar 18, 2015 at 4:07 AM, Andrii Biletskyi > <andrii.bilets...@stealth.ly> wrote: > > Gwen, > > > > Thanks for bringing this up! > > Regarding UpdateMetadata in KIP-4 - no it shouldn't be used in Admin CLI, > > its internal server message. We will probably use TMR there (depends how > > generic re-routing facility goes) but TMR is already used in > NetworkClient, > > so > > I believe there are no doubts about it, it should be ported to java. > > > > Thanks, > > Andrii Biletskyi > > > > > > On Wed, Mar 18, 2015 at 3:13 AM, Jiangjie Qin <j...@linkedin.com.invalid > > > > wrote: > > > >> I think those two requests are only used by controller to broker > >> communication. Not sure if client side will need them in KIP-4, > unlikely I > >> guess. > >> > >> Jiangjie (Becket) Qin > >> > >> On 3/17/15, 6:08 PM, "Gwen Shapira" <gshap...@cloudera.com> wrote: > >> > >> >Hi, > >> > > >> >I'm starting this thread for the various questions I run into while > >> >refactoring the server to use client requests and responses. > >> > > >> >Help is appreciated :) > >> > > >> >First question: LEADER_AND_ISR request and STOP_REPLICA request are > >> >unimplemented in the client. > >> > > >> >Do we want to implement them as part of this refactoring? > >> >Or should we continue using the scala implementation for those? > >> > > >> >Gwen > >> > >> >
