> > How about keeping those server-side for now, since there's no duplication? > We can move them over in a follow-up jira.
+1. The work involved in this refactoring is pretty sizable. I would be ok with splitting it in 2 JIRAs - one that converts the duplicated ones over first and another that converts the rest. On Tue, Mar 17, 2015 at 6:39 PM, Gwen Shapira <gshap...@cloudera.com> wrote: > Never mind, it is implemented. Its just called LIST_OFFSETS. > > > > On Tue, Mar 17, 2015 at 6:27 PM, Gwen Shapira <gshap...@cloudera.com> > wrote: > > Thanks Jiangjie! > > > > Another, more questionable missing-in-action: > > > > Client API had offset fetch request and offset commit requests. I > > understand those :) > > The Server API also has OffsetRequest, which returns offset > > corresponding to a specific time stamp. Its used by consumers. > > > > This sounds like something we actually need on the client side... is > > this dropped with the new consumer? > > > > > > > > > > On Tue, Mar 17, 2015 at 6:13 PM, Jiangjie Qin <j...@linkedin.com.invalid> > wrote: > >> I think those two requests are only used by controller to broker > >> communication. Not sure if client side will need them in KIP-4, > unlikely I > >> guess. > >> > >> Jiangjie (Becket) Qin > >> > >> On 3/17/15, 6:08 PM, "Gwen Shapira" <gshap...@cloudera.com> wrote: > >> > >>>Hi, > >>> > >>>I'm starting this thread for the various questions I run into while > >>>refactoring the server to use client requests and responses. > >>> > >>>Help is appreciated :) > >>> > >>>First question: LEADER_AND_ISR request and STOP_REPLICA request are > >>>unimplemented in the client. > >>> > >>>Do we want to implement them as part of this refactoring? > >>>Or should we continue using the scala implementation for those? > >>> > >>>Gwen > >> > -- Thanks, Neha
