> On Jan. 26, 2015, 2:35 a.m., Neha Narkhede wrote: > > Can we add a test for this? If we add more metrics in the future, hopefully > > that test would fail if we forget to add the new metrics to this > > removeMetrics() API
Added a test please take a look. - Sriharsha ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30084/#review69584 ----------------------------------------------------------- On Feb. 11, 2015, 6:50 a.m., Sriharsha Chintalapani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30084/ > ----------------------------------------------------------- > > (Updated Feb. 11, 2015, 6:50 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1866 > https://issues.apache.org/jira/browse/KAFKA-1866 > > > Repository: kafka > > > Description > ------- > > KAFKA-1866. LogStartOffset gauge throws exceptions after log.delete(). > > > Diffs > ----- > > core/src/main/scala/kafka/cluster/Partition.scala > e6ad8be5e33b6fb31c078ad78f8de709869ddc04 > core/src/main/scala/kafka/log/Log.scala > 846023bb98d0fa0603016466360c97071ac935ea > core/src/test/scala/unit/kafka/metrics/MetricsTest.scala > 3cf23b3d6d4460535b90cfb36281714788fc681c > core/src/test/scala/unit/kafka/utils/TestUtils.scala > 21d0ed2cb7c9459261d3cdc7c21dece5e2079698 > > Diff: https://reviews.apache.org/r/30084/diff/ > > > Testing > ------- > > > Thanks, > > Sriharsha Chintalapani > >
