----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30482/#review71562 -----------------------------------------------------------
Ship it! Ship It! - Jay Kreps On Feb. 6, 2015, 11:02 p.m., Guozhang Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30482/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2015, 11:02 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1333 > https://issues.apache.org/jira/browse/KAFKA-1333 > > > Repository: kafka > > > Description > ------- > > dummy 2 > > > minor > > > three new file > > > Address Jay and Onur's comments > > > Diffs > ----- > > core/src/main/scala/kafka/coordinator/ConsumerCoordinator.scala > PRE-CREATION > core/src/main/scala/kafka/coordinator/ConsumerRegistry.scala PRE-CREATION > core/src/main/scala/kafka/coordinator/DelayedHeartbeat.scala PRE-CREATION > core/src/main/scala/kafka/coordinator/DelayedJoinGroup.scala PRE-CREATION > core/src/main/scala/kafka/coordinator/DelayedRebalance.scala PRE-CREATION > core/src/main/scala/kafka/coordinator/GroupRegistry.scala PRE-CREATION > core/src/main/scala/kafka/coordinator/HeartbeatBucket.scala PRE-CREATION > core/src/main/scala/kafka/network/SocketServer.scala > 39b1651b680b2995cedfde95d74c086d9c6219ef > core/src/main/scala/kafka/server/DelayedOperationKey.scala > fb7e9ed5c16dd15b71e1b1ac12948641185871db > core/src/main/scala/kafka/server/KafkaApis.scala > f2b027bf944e735fd52cc282690ec1b8395f9290 > core/src/main/scala/kafka/server/KafkaServer.scala > 89200da30a04943f0b9befe84ab17e62b747c8c4 > core/src/main/scala/kafka/server/MetadataCache.scala > bf81a1ab88c14be8697b441eedbeb28fa0112643 > core/src/main/scala/kafka/server/OffsetManager.scala > 0bdd42fea931cddd072c0fff765b10526db6840a > core/src/main/scala/kafka/tools/MirrorMaker.scala > 81ae205ef7b2050d0152f29f8da7dd91b17b8b00 > core/src/test/resources/log4j.properties > 1b7d5d8f7d5fae7d272849715714781cad05d77b > core/src/test/scala/integration/kafka/api/ProducerFailureHandlingTest.scala > 90c0b7a19c7af8e5416e4bdba62b9824f1abd5ab > core/src/test/scala/unit/kafka/server/ServerShutdownTest.scala > ba1e48e4300c9fb32e36e7266cb05294f2a481e5 > core/src/test/scala/unit/kafka/utils/TestUtils.scala > 54755e8dd3f23ced313067566cd4ea867f8a496e > > Diff: https://reviews.apache.org/r/30482/diff/ > > > Testing > ------- > > > Thanks, > > Guozhang Wang > >