> On Feb. 8, 2015, 4:07 p.m., Joe Stein wrote: > > dev-utils/test-patch.py, line 147 > > <https://reviews.apache.org/r/29893/diff/4/?file=849124#file849124line147> > > > > What is this structure that comes back? When it sorts does it do the > > latest time first and uses that patch? I am running this right now so not > > much feedback but would like to understand more about which patches we can > > flag for it or do we always go with the latest one? If we ever have a patch > > that has to go in 2 branches then we just then have 2 JIRA which is ok by > > me.
*matches* is basically list of patches attached to a JIRA, in the order of dates they were attached. jira_get_attachment returns the latest patch attached to the JIRA. I have tested this with a few JIRAs, like KAFKA-1634, and it works fine. - Ashish ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29893/#review71574 ----------------------------------------------------------- On Feb. 4, 2015, 11:44 p.m., Ashish Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29893/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2015, 11:44 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1856 > https://issues.apache.org/jira/browse/KAFKA-1856 > > > Repository: kafka > > > Description > ------- > > KAFKA-1856: Add PreCommit Patch Testing > > > Diffs > ----- > > dev-utils/test-patch.py PRE-CREATION > > Diff: https://reviews.apache.org/r/29893/diff/ > > > Testing > ------- > > Tested on KAFKA-1664, > https://issues.apache.org/jira/browse/KAFKA-1664?focusedCommentId=14277439&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14277439 > > How to run: > python dev-utils/test-patch.py --defect KAFKA-1664 --username <user_name> > --password <password> --run-tests --post-results > > > Thanks, > > Ashish Singh > >
