> On Jan. 16, 2015, 7:53 p.m., Sriharsha Chintalapani wrote: > > core/src/main/scala/kafka/javaapi/OffsetCommitRequest.scala, line 22 > > <https://reviews.apache.org/r/29977/diff/1/?file=823660#file823660line22> > > > > Shouldn't this provide another constructor that takes in versionId?
The problem is that in version 1, you can't just send the commit request to any broker as you can do in version 0. - Jun ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29977/#review68459 ----------------------------------------------------------- On Jan. 16, 2015, 8:08 p.m., Jun Rao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29977/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2015, 8:08 p.m.) > > > Review request for kafka. > > > Bugs: kafka-1870 > https://issues.apache.org/jira/browse/kafka-1870 > > > Repository: kafka > > > Description > ------- > > making the fetcOffset() api consistent > > > Diffs > ----- > > core/src/main/scala/kafka/consumer/SimpleConsumer.scala > e53ee51638b930d8592ce9994ae2a617e7ef771c > core/src/main/scala/kafka/javaapi/OffsetCommitRequest.scala > 27fc1eb9d578e31758bb8316a1e541c903b29361 > core/src/main/scala/kafka/javaapi/OffsetFetchRequest.scala > 5b4f4bbcdd606da4521e5d2c9cd7bc2ba674a04a > core/src/main/scala/kafka/javaapi/consumer/SimpleConsumer.scala > 0ab0195dc9f66f407061d0fac2549bd6291e41ff > > Diff: https://reviews.apache.org/r/29977/diff/ > > > Testing > ------- > > > Thanks, > > Jun Rao > >
