----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29977/#review68459 -----------------------------------------------------------
core/src/main/scala/kafka/javaapi/OffsetCommitRequest.scala <https://reviews.apache.org/r/29977/#comment112704> Shouldn't this provide another constructor that takes in versionId? - Sriharsha Chintalapani On Jan. 16, 2015, 7:49 p.m., Jun Rao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29977/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2015, 7:49 p.m.) > > > Review request for kafka. > > > Bugs: kafka-1870 > https://issues.apache.org/jira/browse/kafka-1870 > > > Repository: kafka > > > Description > ------- > > make javaapi.SimpleConsumer.offsetCommits() only commit to ZK > > > Diffs > ----- > > core/src/main/scala/kafka/consumer/SimpleConsumer.scala > e53ee51638b930d8592ce9994ae2a617e7ef771c > core/src/main/scala/kafka/javaapi/OffsetCommitRequest.scala > 27fc1eb9d578e31758bb8316a1e541c903b29361 > core/src/main/scala/kafka/javaapi/consumer/SimpleConsumer.scala > 0ab0195dc9f66f407061d0fac2549bd6291e41ff > > Diff: https://reviews.apache.org/r/29977/diff/ > > > Testing > ------- > > > Thanks, > > Jun Rao > >
