-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29755/
-----------------------------------------------------------
(Updated Jan. 10, 2015, 1:37 p.m.)
Review request for kafka.
Bugs: KAFKA-1853
https://issues.apache.org/jira/browse/KAFKA-1853
Repository: kafka
Description
-------
KAFKA-1853 Fix potential leak of open LogSegment files during deletion of
expired LogSegments. Also fixes the issue of leaving FileMessageSet in a
invalid state in such cases
Diffs
-----
core/src/main/scala/kafka/log/FileMessageSet.scala
b2652ddbe2f857028d5980e29a008b2c614694a3
core/src/main/scala/kafka/log/Log.scala
024506cd00556a0037c0b3b6b603da32968b69ab
Diff: https://reviews.apache.org/r/29755/diff/
Testing (updated)
-------
Have run the existing tests in LogManagerTest (which includes a test for
cleaning of expired LogSegments) and those have passed with this change. I did
give a thought of trying to replicate a failed rename scenario and then to
ensure that we don't leak resources anymore, but that's not straightforward to
do in the tests, so haven't added any new tests.
Thanks,
Jaikiran Pai
