----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29755/#review67382 -----------------------------------------------------------
This is my very first attempt at Scala, so feel free to let me know if anything looks incorrect. I've added a test to ensure that the change at least works as per my expectation. - Jaikiran Pai On Jan. 9, 2015, 6:44 a.m., Jaikiran Pai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29755/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2015, 6:44 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1853 > https://issues.apache.org/jira/browse/KAFKA-1853 > > > Repository: kafka > > > Description > ------- > > Fixes file leaks caused by unsuccessful file rename attempt in LogSegment > > > Diffs > ----- > > core/src/main/scala/kafka/log/FileMessageSet.scala > b2652ddbe2f857028d5980e29a008b2c614694a3 > core/src/test/scala/unit/kafka/log/LogSegmentTest.scala > 03fb3512c4a4450eac83d4cd4b0919baeaa22942 > > Diff: https://reviews.apache.org/r/29755/diff/ > > > Testing > ------- > > > Thanks, > > Jaikiran Pai > >
