-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25995/
-----------------------------------------------------------
(Updated Dec. 7, 2014, 2:59 a.m.)
Review request for kafka.
Bugs: KAFKA-1650 and KAKFA-1650
https://issues.apache.org/jira/browse/KAFKA-1650
https://issues.apache.org/jira/browse/KAKFA-1650
Repository: kafka
Description (updated)
-------
Addressed Guozhang's comments.
Addressed Guozhang's comments
commit before switch to trunk
commit before rebase
Rebased on trunk, Addressed Guozhang's comments.
Addressed Guozhang's comments on MaxInFlightRequests
Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into
mirrormaker-redesign
Incorporated Guozhang's comments
Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into
mirrormaker-redesign
Merged KAFKA-345 into this patch. Incorporated Joel and Jun's comments.
Added consumer rebalance listener to mirror maker, will test it later.
Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into
mirrormaker-redesign
Conflicts:
core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala
core/src/test/scala/unit/kafka/consumer/ZookeeperConsumerConnectorTest.scala
added custom config for consumer rebalance listener
Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into
mirrormaker-redesign
Add configurable consumer rebalance listener
Incorporated Guozhang's comments
Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into
mirrormaker-redesign
Incorporated Guozhang's comments.
Addressed Guozhang's comment.
numMessageUnacked should be decremented no matter the send was successful or
not.
Addressed Jun's comments.
Diffs (updated)
-----
core/src/main/scala/kafka/consumer/ConsumerConnector.scala
62c0686e816d2888772d5a911becf625eedee397
core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala
da29a8cb461099eb675161db2f11a9937424a5c6
core/src/main/scala/kafka/javaapi/consumer/ConsumerRebalanceListener.java
PRE-CREATION
core/src/main/scala/kafka/javaapi/consumer/ZookeeperConsumerConnector.scala
9d5a47fb8e04d0055cce820afde7f73affc0a984
core/src/main/scala/kafka/tools/MirrorMaker.scala
f399105087588946987bbc84e3759935d9498b6a
core/src/main/scala/kafka/utils/ByteBoundedBlockingQueue.scala
6a85d7e494f6c88798133a17f6180b61029dff58
core/src/test/scala/unit/kafka/consumer/ZookeeperConsumerConnectorTest.scala
8c4687b2c96fddab7c8454a5a8011c3bab0897a0
Diff: https://reviews.apache.org/r/25995/diff/
Testing
-------
Thanks,
Jiangjie Qin
