[ 
https://issues.apache.org/jira/browse/KAFKA-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14208275#comment-14208275
 ] 

Guozhang Wang commented on KAFKA-1737:
--------------------------------------

Hi Vivek,

Here are my thoughts: since currently we only use a single data format 
(ZkStringSerializer) in Kafka's ZK, we could just enforce it in ZkClient 
construction time; but as you mentioned, people can pass any ZkClient instances 
to the AdminUtils API functions using "new ZkClient" it is a bit hard to 
enforce it programmatically, and instead I was proposing to add a new 
createZkClient function and let people to use it instead of calling "new 
ZkClient" to create new instances. Of course we still need to change the docs 
telling people to do so, not using "new".

> Document required ZkSerializer for ZkClient used with AdminUtils
> ----------------------------------------------------------------
>
>                 Key: KAFKA-1737
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1737
>             Project: Kafka
>          Issue Type: Improvement
>          Components: tools
>    Affects Versions: 0.8.1.1
>            Reporter: Stevo Slavic
>            Priority: Minor
>
> {{ZkClient}} instances passed to {{AdminUtils}} calls must have 
> {{kafka.utils.ZKStringSerializer}} set as {{ZkSerializer}}. Otherwise 
> commands executed via {{AdminUtils}} may not be seen/recognizable to broker, 
> producer or consumer. E.g. producer (with auto topic creation turned off) 
> will not be able to send messages to a topic created via {{AdminUtils}}, it 
> will throw {{UnknownTopicOrPartitionException}}.
> Please consider at least documenting this requirement in {{AdminUtils}} 
> scaladoc.
> For more info see [related discussion on Kafka user mailing 
> list|http://mail-archives.apache.org/mod_mbox/kafka-users/201410.mbox/%3CCAAUywg-oihNiXuQRYeS%3D8Z3ymsmEHo6ghLs%3Dru4nbm%2BdHVz6TA%40mail.gmail.com%3E].



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to