[ 
https://issues.apache.org/jira/browse/KAFKA-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14204924#comment-14204924
 ] 

Guozhang Wang commented on KAFKA-1737:
--------------------------------------

Originally when I discussed with [~sslavic] I think we should set the doc clear 
about this, but actually ZkStringSerializer should be the "only" serializer we 
use in Kafka now until we extend it to support multiple data format. So I agree 
that we could just enforce it in the ZkClient constructor, maybe via:

1. add a createZkClient in Utils like createProducer / createBroker, etc, that 
enforce ZkStringSerializer.
2. change the code everywhere to use this createZkClient instead of "new 
ZkClient".

> Document required ZkSerializer for ZkClient used with AdminUtils
> ----------------------------------------------------------------
>
>                 Key: KAFKA-1737
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1737
>             Project: Kafka
>          Issue Type: Improvement
>          Components: tools
>    Affects Versions: 0.8.1.1
>            Reporter: Stevo Slavic
>            Priority: Minor
>
> {{ZkClient}} instances passed to {{AdminUtils}} calls must have 
> {{kafka.utils.ZKStringSerializer}} set as {{ZkSerializer}}. Otherwise 
> commands executed via {{AdminUtils}} may not be seen/recognizable to broker, 
> producer or consumer. E.g. producer (with auto topic creation turned off) 
> will not be able to send messages to a topic created via {{AdminUtils}}, it 
> will throw {{UnknownTopicOrPartitionException}}.
> Please consider at least documenting this requirement in {{AdminUtils}} 
> scaladoc.
> For more info see [related discussion on Kafka user mailing 
> list|http://mail-archives.apache.org/mod_mbox/kafka-users/201410.mbox/%3CCAAUywg-oihNiXuQRYeS%3D8Z3ymsmEHo6ghLs%3Dru4nbm%2BdHVz6TA%40mail.gmail.com%3E].



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to