----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26373/#review58748 -----------------------------------------------------------
Ship it! Looks good to me. Can you make these final edits and upload another RB? core/src/main/scala/kafka/server/ReplicaManager.scala <https://reviews.apache.org/r/26373/#comment99891> The .format needs to be on this line. Can you fix it and upload a new patch? core/src/main/scala/kafka/server/ReplicaManager.scala <https://reviews.apache.org/r/26373/#comment99892> Small edits: // Create the local replica even if the leader is unavailable. This is required to ensure that we include the partition's high watermark in the checkpoint file (see KAFKA-1647) Also, I'm not sure if we need to explicitly reference the jira in comments since people can just git annotate. - Joel Koshy On Oct. 28, 2014, 12:20 a.m., Jiangjie Qin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26373/ > ----------------------------------------------------------- > > (Updated Oct. 28, 2014, 12:20 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1647 > https://issues.apache.org/jira/browse/KAFKA-1647 > > > Repository: kafka > > > Description > ------- > > Addressed Joel's comments. > > > the version 2 code seems to be submitted by mistake... This should be the > code for review that addressed Joel's comments. > > > Addressed Jun's comments. Will do tests to verify if it works. > > > Addressed Joel's comments, we do not need to check the if leader exits for > not when adding fetcher. > > > Diffs > ----- > > core/src/main/scala/kafka/server/ReplicaManager.scala > 78b7514cc109547c562e635824684fad581af653 > > Diff: https://reviews.apache.org/r/26373/diff/ > > > Testing > ------- > > Followed Joel's testing step. I was able to reproduce the problem without the > patch and the WARN message goes away after applied the patch. > > > Thanks, > > Jiangjie Qin > >
