> On Oct. 23, 2014, 12:42 a.m., Jun Rao wrote: > > core/src/main/scala/kafka/server/ReplicaManager.scala, lines 531-538 > > <https://reviews.apache.org/r/26373/diff/4/?file=728653#file728653line531> > > > > I am not sure that I understand how Option.flatten works. Would it be > > clearly if we first filter out partitions with no live leader and then > > generate the TopicAndPartition to BrokerAndInitialOffset map?
This change actually should be reverted as Joel suggested because we no longer add the partition without leader to partitionsToMakeFollower any more, instead, we only create local replica for it. This section should be exactly same as the original code. I put flattern here to just remove the None option from a set... - Jiangjie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26373/#review57947 ----------------------------------------------------------- On Oct. 22, 2014, 6:08 a.m., Jiangjie Qin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26373/ > ----------------------------------------------------------- > > (Updated Oct. 22, 2014, 6:08 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1647 > https://issues.apache.org/jira/browse/KAFKA-1647 > > > Repository: kafka > > > Description > ------- > > Addressed Joel's comments. > > > the version 2 code seems to be submitted by mistake... This should be the > code for review that addressed Joel's comments. > > > Addressed Jun's comments. Will do tests to verify if it works. > > > Diffs > ----- > > core/src/main/scala/kafka/server/ReplicaManager.scala > 78b7514cc109547c562e635824684fad581af653 > > Diff: https://reviews.apache.org/r/26373/diff/ > > > Testing > ------- > > > Thanks, > > Jiangjie Qin > >
