> On Aug. 18, 2014, 5:32 p.m., Joel Koshy wrote: > > I should be able to review this later today. However, as Jun also mentioned > > can you please run the stress test? When I was working on the original > > (WIP) patch it worked but eventually failed (due to various reasons such as > > corrupt message sizes, etc) on a stress test after several segments had > > rolled and after several log cleaner runs - although I didn't get time to > > look into it your patch should have hopefully addressed these issues.
I tested the patch with my own test code and it is working fine. I ran TestLogCleaning stress test. Some times this test is failing. But i am not getting any broker-side errors/corrupt messages. I also ran TestLogCleaning on trunk (without my patch). This test is failing for multiple topics. I am looking into TestLogCleaning code and trying fix if any issue. I will keep you updated on the testing status. - Manikumar Reddy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24214/#review50901 ----------------------------------------------------------- On Sept. 23, 2014, 4:20 p.m., Manikumar Reddy O wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24214/ > ----------------------------------------------------------- > > (Updated Sept. 23, 2014, 4:20 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1374 > https://issues.apache.org/jira/browse/KAFKA-1374 > > > Repository: kafka > > > Description > ------- > > Addresing Jun's comments > > > Diffs > ----- > > core/src/main/scala/kafka/log/LogCleaner.scala > c20de4ad4734c0bd83c5954fdb29464a27b91dff > core/src/main/scala/kafka/tools/TestLogCleaning.scala > 1d4ea93f2ba8d4d4d47a307cd47f54a15d3d30dd > core/src/test/scala/unit/kafka/log/LogCleanerIntegrationTest.scala > 5bfa764638e92f217d0ff7108ec8f53193c22978 > > Diff: https://reviews.apache.org/r/24214/diff/ > > > Testing > ------- > > > Thanks, > > Manikumar Reddy O > >
