> On Aug. 18, 2014, 5:21 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/log/LogCleaner.scala, lines 436-438 > > <https://reviews.apache.org/r/24214/diff/3-5/?file=657031#file657031line436> > > > > Hmm, I think the original approach of throwing an exception is probably > > better. When handling the produce requests, we can reject messages w/o a > > key, if the topic is configured with compaction. Once we do that, there > > should be no messages with null key during compaction. If that happens, we > > should just fail the broker.
Ok.. I reverted the changes. We will revisit the solution in KAFKA-1581 > On Aug. 18, 2014, 5:21 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/log/LogCleaner.scala, lines 479-481 > > <https://reviews.apache.org/r/24214/diff/5/?file=658590#file658590line479> > > > > Could we use MemoryRecords.RecordsIterator to iterate compressed > > messages? This chage required some complicated, So i am dropping this issue. - Manikumar Reddy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24214/#review50893 ----------------------------------------------------------- On Sept. 23, 2014, 4:20 p.m., Manikumar Reddy O wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24214/ > ----------------------------------------------------------- > > (Updated Sept. 23, 2014, 4:20 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1374 > https://issues.apache.org/jira/browse/KAFKA-1374 > > > Repository: kafka > > > Description > ------- > > Addresing Jun's comments > > > Diffs > ----- > > core/src/main/scala/kafka/log/LogCleaner.scala > c20de4ad4734c0bd83c5954fdb29464a27b91dff > core/src/main/scala/kafka/tools/TestLogCleaning.scala > 1d4ea93f2ba8d4d4d47a307cd47f54a15d3d30dd > core/src/test/scala/unit/kafka/log/LogCleanerIntegrationTest.scala > 5bfa764638e92f217d0ff7108ec8f53193c22978 > > Diff: https://reviews.apache.org/r/24214/diff/ > > > Testing > ------- > > > Thanks, > > Manikumar Reddy O > >
