[ 
https://issues.apache.org/jira/browse/KAFKA-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14134699#comment-14134699
 ] 

Sriharsha Chintalapani commented on KAFKA-1558:
-----------------------------------------------

[~junrao] [~nehanarkhede] I ran tests for above cases manually on a cluster 3 
kafka nodes and 3 zookeeper nodes
for each of the tests topics are created and minimum size of the log per 
partition was > 1Gb

1)  after the controller is restarted
   issuing delete topic is successful , metadata is deleted and also the log 
file without any errors.

2)  after a soft failure (can simulate by pausing the jvm for longer that zk 
session timeout) of the controller
   I am not sure how to induce a pause in jvm , I tried with debug tools 
doesn't look it had any effect. If you have any pointers on this please let me 
know.

3)  after a topic's partitions have been reassigned to some other brokers
     used kafka-reassign-partitions and ran delete topic command this resulted 
in successful deleting of metadata and topics log files

4) after running a preferred leader command
     No issues here topic successfully deleted

5) after a topic's partition has been increased
    No issues here either . new partition data also deleted

6) controller broker is killed (kill -9)
  successfully deleted the topic and metadata. Once the killed controller back 
online the logfiles for that topic also got deleted.

Please let me know on the case 2. If you have any more cases that you would 
like to test please let me know.
Thanks.

> AdminUtils.deleteTopic does not work
> ------------------------------------
>
>                 Key: KAFKA-1558
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1558
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.8.1.1
>            Reporter: Henning Schmiedehausen
>            Assignee: Sriharsha Chintalapani
>            Priority: Blocker
>             Fix For: 0.8.2
>
>
> the AdminUtils:.deleteTopic method is implemented as
> {code}
>     def deleteTopic(zkClient: ZkClient, topic: String) {
>         ZkUtils.createPersistentPath(zkClient, 
> ZkUtils.getDeleteTopicPath(topic))
>     }
> {code}
> but the DeleteTopicCommand actually does
> {code}
>     zkClient = new ZkClient(zkConnect, 30000, 30000, ZKStringSerializer)
>     zkClient.deleteRecursive(ZkUtils.getTopicPath(topic))
> {code}
> so I guess, that the 'createPersistentPath' above should actually be 
> {code}
>     def deleteTopic(zkClient: ZkClient, topic: String) {
>         ZkUtils.deletePathRecursive(zkClient, ZkUtils.getTopicPath(topic))
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to