[ https://issues.apache.org/jira/browse/KAFKA-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14129506#comment-14129506 ]
Gwen Shapira commented on KAFKA-1558: ------------------------------------- I don't think the issue as described above exists an more. I tested the trunk implementation of deleteTopic in simple cases and in all of them, if delete.topic.enable was true, the topic was deleted. I think what we need now is to test deleteTopic under failure modes - leader election, partition reassignment, etc. > AdminUtils.deleteTopic does not work > ------------------------------------ > > Key: KAFKA-1558 > URL: https://issues.apache.org/jira/browse/KAFKA-1558 > Project: Kafka > Issue Type: Bug > Affects Versions: 0.8.1.1 > Reporter: Henning Schmiedehausen > Assignee: Sriharsha Chintalapani > Priority: Blocker > Fix For: 0.8.2 > > > the AdminUtils:.deleteTopic method is implemented as > {code} > def deleteTopic(zkClient: ZkClient, topic: String) { > ZkUtils.createPersistentPath(zkClient, > ZkUtils.getDeleteTopicPath(topic)) > } > {code} > but the DeleteTopicCommand actually does > {code} > zkClient = new ZkClient(zkConnect, 30000, 30000, ZKStringSerializer) > zkClient.deleteRecursive(ZkUtils.getTopicPath(topic)) > {code} > so I guess, that the 'createPersistentPath' above should actually be > {code} > def deleteTopic(zkClient: ZkClient, topic: String) { > ZkUtils.deletePathRecursive(zkClient, ZkUtils.getTopicPath(topic)) > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)