Chris, 1) The expectation today is that we have a green PR build before merging. This is sometimes relaxed in light of flaky tests at the discretion of the committer merging the PR. In general, we should expect a green build before merging a PR. This KIP does not change that requirement.
2) I expect it's probably in the 10s of minutes for the unit test suite. Adding the unit tests to the merge queue workflow is certainly something we can consider after we've rolled it out. One thing to keep in mind is that any flakiness in the merge queue workflow will be very disruptive. It will essentially kick the PR back to the author and will need to be enqueued again. Christo, The merge queue validation will be in addition to our usual PR testing workflow. Think of it as an extra bit of validation that happens after the committer clicks the green merge button. So the sequence of events would be: * New PR opened * Existing CI workflow is run, green build obtained * Committer approval * Committer clicks "Merge when ready" * PR added to merge queue * Additional checks as part of merge queue workflow * PR is merged to trunk Thanks! -David A On Fri, Jan 24, 2025 at 6:10 AM Christo Lolov <christolo...@gmail.com> wrote: > Heya David, > > Thanks a lot for this! > > Building on top of Chris's questions - does including only a subset of the > stages in the merge queue mean that while subsequent stages (i.e. tests) > can run in parallel-ish across PRs they will contain trunk + set of PRs > ahead of this one which passed the stage in the merge queue + this PR? Or > am I misunderstanding the sequence of events? > > Best, > Christo > > On Fri, 24 Jan 2025 at 04:20, Chris Egerton <fearthecel...@gmail.com> > wrote: > > > Hi David, > > > > Thanks for the KIP, and for your ongoing work to improve Kafka CI. > > > > Two small thoughts: > > > > 1) Today, there's a convention of waiting for a green (or at least > > completed) CI build before merging PRs, which includes running the full > > test suite. This can be relaxed on a case-by-case basis but it's > generally > > expected for most PRs. > > > > Since we won't be running the full test suite in the merge queue, would I > > be correct in assuming that it is not a goal of this KIP to further relax > > that convention? > > > > 2) Do you have an estimate on the expected build time if we add unit > tests? > > I'm wondering if it would be feasible to enable them in the merge queue. > > > > Cheers, > > > > Chris > > > > On Thu, Jan 23, 2025, 22:06 Ukpa Uchechi <ukpauchec...@gmail.com> wrote: > > > > > Hey David, > > > > > > Is the credentials for Confluent data center different from the one > used > > to > > > access Apache Kafka jira? > > > > > > Best Regards. > > > > > > On Fri, 24 Jan 2025 at 03:35, David Arthur <mum...@gmail.com> wrote: > > > > > > > Greetings, Kafka community! > > > > > > > > At long last, the GitHub Merge Queue is upon us. This is a feature > that > > > > many of us have wanted for quite a while. After many months of > > > discussion, > > > > the excellent ASF Infra team has delivered! > > > > > > > > Since this is quite a significant change, I have written up the > details > > > as > > > > a KIP. > > > > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-1126%3A+Serialize+changes+to+Kafka+with+build+queue > > > > > > > > Please let me know what you think. > > > > > > > > -- > > > > David Arthur > > > > > > > > > > -- David Arthur
