+1 (binding). Thanks for the KIP! On Mon, Nov 11, 2024 at 9:41 AM Luke Chen <show...@gmail.com> wrote:
> +1 (binding) from me. > > Thanks for the KIP. > > Luke > > On Mon, Nov 11, 2024 at 10:51 AM TengYao Chi <kiting...@gmail.com> wrote: > > > Hi > > Thanks for KIP. > > +1 (non-binding) > > > > Best, > > TengYao > > > > 黃竣陽 <s7133...@gmail.com> 於 2024年11月11日 週一 上午10:41寫道： > > > > > Hello everyone, > > > I hope this message finds you well. > > > As the vote has been pending for three weeks, I would like to push it > > > manually. > > > > > > Thank you for your attention. > > > Best regards, > > > Jiunn-Yang > > > > > > > 黃竣陽 <s7133...@gmail.com> 於 2024年9月28日 上午10:04 寫道： > > > > > > > > Hello everyone, > > > > I hope this message finds you well. > > > > As the vote has been pending for more than two weeks, I would like to > > > push it > > > > manually. > > > > > > > > Thank you for your attention. > > > > Best regards, > > > > Jiunn-Yang > > > > > > > >> Lianet M. <liane...@gmail.com> 於 2024年9月10日 晚上11:06 寫道： > > > >> > > > >> Hello, > > > >> > > > >> Thanks for updating the KIP. Looks good to me now. > > > >> > > > >> +1 (binding) > > > >> > > > >> Lianet > > > >> > > > >> > > > >> On Thu, Sep 5, 2024, 8:29 p.m. 黃竣陽 <s7133...@gmail.com> wrote: > > > >> > > > >>> It make sense to me, I will change to > > > >>> `CreateDelegationTokenRequestData.setMaxLifetimeMs` > > > >>> > > > >>>> Chia-Ping Tsai <chia7...@gmail.com> 於 2024年9月5日 晚上11:22 寫道： > > > >>>> > > > >>>>> it aligns better with the RPC field (max_lifetime_ms) > > > >>>> > > > >>>> That makes sense to me. +1 to align it > > > >>>> > > > >>>> Best, > > > >>>> Chia-Ping > > > >>>> > > > >>>> Lianet M. <liane...@gmail.com> 於 2024年9月5日 週四 下午11:13寫道： > > > >>>> > > > >>>>> Hey all, just one small comment: shouldn't the new method be > named > > " > > > >>>>> maxLifetimeMs()" (Lifetime vs LifeTime)? I believe it's the right > > > >>> spelling, > > > >>>>> but mostly, it aligns better with the RPC field > (max_lifetime_ms), > > > that > > > >>>>> generates a CreateDelegationTokenRequestData.maxLifetimeMs() and > > > >>>>> CreateDelegationTokenRequestData.setMaxLifetimeMs(...) > > > >>>>> > > > >>>>> Thanks! > > > >>>>> > > > >>>>> Lianet > > > >>>>> > > > >>>>> On Thu, Sep 5, 2024 at 9:36 AM Chia-Ping Tsai < > chia7...@gmail.com> > > > >>> wrote: > > > >>>>> > > > >>>>>> +1 (binding) > > > >>>>>> > > > >>>>>> 黃竣陽 <s7133...@gmail.com> 於 2024年9月5日 週四 下午9:08寫道： > > > >>>>>> > > > >>>>>>> Hello everyone, > > > >>>>>>> > > > >>>>>>> I would like to call for a vote on KIP-1080: < > > > >>>>>>> > > > >>>>>> > > > >>>>> > > > >>> > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-1080%3A+Fix+the+typo%3A+%60maxlifeTimeMs%60+in+CreateDelegationTokenOptions > > > >>>>>>>> > > > >>>>>>> > > > >>>>>>> The discussion can be found here: > > > >>>>>>> < > > https://lists.apache.org/thread/00jvqxoo6d59k5z5cjm9wtj6dd075vro> > > > >>>>>>> > > > >>>>>>> Best regards, > > > >>>>>>> Jiunn-Yang > > > >>>>>> > > > >>>>> > > > >>> > > > >>> > > > > > > > > > > > > >
