Hi Muralidhar, Thanks for working on this. Can you give some context here about whether slf4j 1 is still maintained? And what code changes are needed to move to slf4j2?
The KIP says that "we also provide the compatible binding jars of a few backends like logback, log4j, reload4j, commons logging in kafka itself." I think if we're going to do this we should fully specify the jars we're providing, not just say "a few jars like...". I'm also not totally convinced that we need to provide so many logging systems. It feels odd to bring in so many dependencies without having a clear idea of who is using them. We didn't do this earlier and nobody complained. Putting more stuff on the CLASSPATH can lead to problems for people. best, Colin On Wed, Sep 11, 2024, at 00:36, Muralidhar Basani wrote: > Hi Chia, thank you for the vote. > I have updated kip motivation with it. > > Thanks, > Murali > > On Wed, Sep 11, 2024 at 8:15 AM Chia-Ping Tsai <chia7...@gmail.com> wrote: > >> +1 (binding) >> >> BTW, could you please add "compatibility issue" to the motivation? >> >> the version of slf4j provider must be equal to slf4j API [0]. Including >> both in kafka distribution can avoid compatibility issue; >> >> [0] https://www.slf4j.org/manual.html#compatibility >> >> Muralidhar Basani <muralidhar.bas...@aiven.io.invalid> 於 2024年9月11日 週三 >> 上午4:02寫道: >> >> > Hi all, >> > >> > I would like to call a vote on KIP-1064 - Upgrade slf4j to 2.x >> > >> > Target version : 4.0.0 >> > >> > KIP - >> > >> > >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1064%3A+Upgrade+slf4j+to+2.x >> > >> > Discussion thread - >> > https://lists.apache.org/thread/z05rlzbjv89rpvzjmzsr8v4w17qn21r1 >> > >> > Jira with some discussion : >> > https://issues.apache.org/jira/browse/KAFKA-16936 >> > >> > Thanks, >> > Murali >> > >>