Hi, Kamal,

Thanks for the KIP. Just a couple of minor comments.

Since we use the purgatory name as the metric tag, could you spell out the
exact new purgatory name for remote list offset?
  private val metricsTags = Map("delayedOperation" -> purgatoryName).asJava
  metricsGroup.newGauge("PurgatorySize", () => watched, metricsTags)
  metricsGroup.newGauge("NumDelayedOperations", () => numDelayed,
metricsTags)

Why is the ExpiresPerSec metric tagged at topic level instead of the
partition level like the produce request or the global level like the fetch
request?

Jun

On Fri, Aug 2, 2024 at 12:04 AM Kamal Chandraprakash <
kamal.chandraprak...@gmail.com> wrote:

> Hi all,
>
> I would like to start a discussion thread on KIP-1075
> <
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1075%3A+Introduce+delayed+remote+list+offsets+purgatory+to+make+LIST_OFFSETS+async
> >
> to
> make the remote LIST_OFFSETS an async operation.
>
> The KIP is here:
>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1075%3A+Introduce+delayed+remote+list+offsets+purgatory+to+make+LIST_OFFSETS+async
>
> Draft PR: https://github.com/apache/kafka/pull/16602
>
> Please take a look. Feedbacks and suggestions are welcome.
>
> Thanks,
> Kamal
>

Reply via email to