----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24620/#review50784 -----------------------------------------------------------
core/src/main/scala/kafka/server/KafkaApis.scala <https://reviews.apache.org/r/24620/#comment88649> Since we will be adding more internal topics over time, this should probably be: && !(isOffsetTopic && topicAndPartition.topic == OffsetManager.OffsetsTopicName) We can fix that on check-in. Overall, the offset commit handling is a bit hacky and KAFKA-1583 should significantly improve the overall structure. - Joel Koshy On Aug. 15, 2014, 1:21 a.m., Jonathan Natkins wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24620/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2014, 1:21 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1580 > https://issues.apache.org/jira/browse/KAFKA-1580 > > > Repository: kafka > > > Description > ------- > > KAFKA-1580 Reject producer requests to internal topics > > > Diffs > ----- > > > clients/src/main/java/org/apache/kafka/common/errors/InvalidTopicException.java > PRE-CREATION > clients/src/main/java/org/apache/kafka/common/protocol/Errors.java > 3374bd98be8e565608c4e764ed10afdae383fb6f > core/src/main/scala/kafka/common/ErrorMapping.scala > 5559d26ba2b96059f719754a351fa4598ca8a70b > core/src/main/scala/kafka/server/KafkaApis.scala > bb94673c8f3079a4053e0a7d58689e69775cdf8b > core/src/test/scala/integration/kafka/api/ProducerFailureHandlingTest.scala > 789e74c776d99f204e0ef87eba1f55a3551abdf2 > > Diff: https://reviews.apache.org/r/24620/diff/ > > > Testing > ------- > > > Thanks, > > Jonathan Natkins > >
