----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24620/#review50669 -----------------------------------------------------------
clients/src/main/java/org/apache/kafka/common/protocol/Errors.java <https://reviews.apache.org/r/24620/#comment88525> I meant adding the existing InvalidTopicException here. I'm not sure if there is value in differentiting amongst all the reasons the topic is invalid. We could just return the generic InvalidTopicException. Sorry if my suggestion wasn't clear enough. - Neha Narkhede On Aug. 14, 2014, 11:56 p.m., Jonathan Natkins wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24620/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2014, 11:56 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1580 > https://issues.apache.org/jira/browse/KAFKA-1580 > > > Repository: kafka > > > Description > ------- > > KAFKA-1580 Reject producer requests to internal topics > > > Diffs > ----- > > > clients/src/main/java/org/apache/kafka/common/errors/InternalTopicOperationException.java > PRE-CREATION > clients/src/main/java/org/apache/kafka/common/protocol/Errors.java > 3374bd98be8e565608c4e764ed10afdae383fb6f > core/src/main/scala/kafka/common/ErrorMapping.scala > 5559d26ba2b96059f719754a351fa4598ca8a70b > core/src/main/scala/kafka/common/InternalTopicOperationException.scala > PRE-CREATION > core/src/main/scala/kafka/server/KafkaApis.scala > bb94673c8f3079a4053e0a7d58689e69775cdf8b > core/src/test/scala/integration/kafka/api/ProducerFailureHandlingTest.scala > 789e74c776d99f204e0ef87eba1f55a3551abdf2 > > Diff: https://reviews.apache.org/r/24620/diff/ > > > Testing > ------- > > > Thanks, > > Jonathan Natkins > >
