Hi Omnia, Thanks for the KIP! Two small things come to mind:
1. It'd be nice to mention that increasing the max offset lag to INT_MAX could work as a partial workaround for users on existing versions (though of course this wouldn't prevent creation of the syncs topic). 2. Will it be illegal to disable offset syncs if other features that rely on offset syncs are explicitly enabled in the connector config? If they're not explicitly enabled then it should probably be fine to silently disable them, but I'd be interested in your thoughts. Cheers, Chris On Wed, Apr 3, 2024, 20:41 Luke Chen <show...@gmail.com> wrote: > Hi Omnia, > > Thanks for the KIP! > It LGTM! > But I'm not an expert of MM2, it would be good to see if there is any other > comment from MM2 experts. > > Thanks. > Luke > > On Thu, Mar 14, 2024 at 6:08 PM Omnia Ibrahim <o.g.h.ibra...@gmail.com> > wrote: > > > Hi everyone, I would like to start a discussion thread for KIP-1031: > > Control offset translation in MirrorSourceConnector > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-1031%3A+Control+offset+translation+in+MirrorSourceConnector > > > > Thanks > > Omnia > > >
