Hi Krishna, thanks for the updates, LGTM.
On Mon, Oct 30, 2023 at 3:36 PM Krishna Agarwal <krishna0608agar...@gmail.com> wrote: > > Hi Federico, > Thanks for the feedback. > > 1. Yes, we will add the building, testing and scanning automation for > this Docker Image along with the flow mentioned in KIP-975. (Updated in the > KIP) > 2. Added the other alternatives to the "rejected alternatives" section, > instead of the main sections. (Updated in the KIP) > 3. Regarding the release process- In the KIP-975, it was concluded that > there shouldn't be any docker specific release process. If there is a high > severity CVE, we should release a new version of Kafka for the affected > branch. It would include the latest Kafka code from the branch. In my > opinion we should keep the same release process here for consistency. > (Updated in the KIP) > KIP-975 Release Process: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-975%3A+Docker+Image+for+Apache+Kafka#KIP975:DockerImageforApacheKafka-ReleaseProcess > Discussion thread for the same: > https://lists.apache.org/thread/05t8ccvhp3fotfftgm7dzn8wobkl59l4 > > > Regards, > Krishna > > On Wed, Oct 25, 2023 at 9:50 PM Federico Valeri <fedeval...@gmail.com> > wrote: > > > Hi Krishna, thanks for updating the KIP and all the work you are > > putting into that. > > > > The release process LGTM. In the other KIP I see that there will be > > some automation for building, testing and scanning for CVEs. Is this > > also true for native images? > > > > I see you are proposing to use Alpine as the base image. I would add > > Distroless to the rejected alternatives with the motivation. Maybe we > > can do the same for the GraalVM distribution of choice. > > > > On Fri, Oct 20, 2023 at 12:02 PM Manikumar <manikumar.re...@gmail.com> > > wrote: > > > > > > Hi, > > > > > > > For the native AK docker image, we are considering '*kafka-local*' as > > it > > > clearly signifies that this image is intended exclusively for local > > > > > > I am not sure, if there is any naming pattern for graalvm based images. > > Can > > > we include "graalvm" to the image name like "kafka-graalvm-native". > > > This will clearly indicate this is graalvm based image. > > > > > > > > > Thanks. Regards > > > > > > > > > > > > > > > On Wed, Oct 18, 2023 at 9:26 PM Krishna Agarwal < > > > krishna0608agar...@gmail.com> wrote: > > > > > > > Hi Federico, > > > > Thanks for the feedback and apologies for the delay. > > > > > > > > I've included a section in the KIP on the release process. I would > > greatly > > > > appreciate your insights after reviewing it. > > > > > > > > Regards, > > > > Krishna > > > > > > > > On Fri, Sep 8, 2023 at 3:08 PM Federico Valeri <fedeval...@gmail.com> > > > > wrote: > > > > > > > > > Hi Krishna, thanks for opening this discussion. > > > > > > > > > > I see you created two separate KIPs (974 and 975), but there are some > > > > > common points (build system and test plan). > > > > > > > > > > Currently, the Docker image used for system tests is only supported > > in > > > > > that limited scope, so the maintenance burden is minimal. Providing > > > > > official Kafka images would be much more complicated. Have you > > > > > considered how the image rebuild process would work in case a high > > > > > severity CVE comes out for a non Kafka image dependency? In that > > case, > > > > > there will be no Kafka release. > > > > > > > > > > Br > > > > > Fede > > > > > > > > > > On Fri, Sep 8, 2023 at 9:17 AM Krishna Agarwal > > > > > <krishna0608agar...@gmail.com> wrote: > > > > > > > > > > > > Hi, > > > > > > I want to submit a KIP to deliver an experimental Apache Kafka > > docker > > > > > image. > > > > > > The proposed docker image can launch brokers with sub-second > > startup > > > > time > > > > > > and minimal memory footprint by leveraging a GraalVM based native > > Kafka > > > > > > binary. > > > > > > > > > > > > KIP-974: Docker Image for GraalVM based Native Kafka Broker > > > > > > < > > > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-974%3A+Docker+Image+for+GraalVM+based+Native+Kafka+Broker > > > > > > > > > > > > > > > > > > Regards, > > > > > > Krishna > > > > > > > > > > >
