Hi Jun, I updated the KIP to include the inter-broker protocol version deprecation.
Ismael On Mon, Jan 9, 2023 at 3:53 PM Jun Rao <j...@confluent.io.invalid> wrote: > Hi, Ismael, > > Thanks for the reply. > > 2. Yes, that makes sense. > > Jun > > On Mon, Jan 9, 2023 at 11:26 AM Ismael Juma <ism...@juma.me.uk> wrote: > > > Hi Jun, > > > > Thanks for the feedback. > > > > 1. Good question. I was looking at the IBP issue as more of an inter > broker > > protocol communication thing and hence I thought we'd cover that as part > of > > the KIP that modernizes that aspect (yet to be written). I filed a JIRA > > recently that shares some of the thinking: > > https://issues.apache.org/jira/browse/KAFKA-14552. I was hoping we would > > tackle the details of that as part of the zk deprecation/removal. You're > > right though that we need to deprecate IBP before 2.1 as part of this KIP > > since we are removing some of the protocol API versions that would be > > required for that to work. I'll update the KIP to include this. > > > > 2. I believe they are all introduced after 2.1, yes. This is what I used > as > > the source for 2.1: > > > > > https://github.com/apache/kafka/blob/2.1/clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java#L189 > > . > > Note that I excluded inter broker protocol APIs like LeaderAndIsr, > > StopReplica and others for the reason I explained in `1`. Does that make > > sense? > > > > Ismael > > > > On Mon, Jan 9, 2023 at 11:01 AM Jun Rao <j...@confluent.io.invalid> > wrote: > > > > > Hi, Ismael, > > > > > > Thanks for the KIP. A couple of comments. > > > > > > 1. Should we deprecate IBPs before 2.1 too? > > > > > > 2. There seem to be more requests than those listed in the KIP. Are > they > > > all introduced after 2.1? > > > > > > Thanks, > > > > > > Jun > > > > > > > > > > > > On Sat, Jan 7, 2023 at 5:13 PM Ismael Juma <ism...@juma.me.uk> wrote: > > > > > > > Hi all, > > > > > > > > I updated the KIP to make it explicit that the Java clients shipped > > with > > > > Apache Kafka 4.0 would only be guaranteed to work with brokers > running > > > > Apache Kafka 2.1 or newer, since they too would no longer have access > > to > > > > the removed protocol APIs. Thanks to Jason for asking about this > aspect > > > > offline. > > > > > > > > I will leave this KIP open for discussion for another couple or weeks > > or > > > > so. Please do share your thoughts given the high impact of the > change. > > > > > > > > Ismael > > > > > > > > On Tue, Jan 3, 2023 at 8:17 AM Ismael Juma <ism...@juma.me.uk> > wrote: > > > > > > > > > Hi all, > > > > > > > > > > I would like to start a discussion regarding the removal of very > old > > > > > client protocol API versions in Apache Kafka 4.0 to improve > > > > maintainability > > > > > & supportability of Kafka. Please take a look at the proposal: > > > > > > > > > > > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-896%3A+Remove+old+client+protocol+API+versions+in+Kafka+4.0 > > > > > > > > > > Ismael > > > > > > > > > > > > > > >
