Hi Jose, 1. The SCRAM in SCRAM-SHA-256 is required as the mechanism name is SCRAM-SHA-256. I do realize there is a bit of redundancy here.
2. I'll add documentation for all the possible values. They are SCRAM-SHA-256 and SCRAM-SHA-512. 3. I'd like to keep it with a capital letter as it is a specific type of message we want to insert. I do agree that -A is not the correct choice so I'll suggest -S for SCRAM and that leaves -A for --add-acl and -a for a generic --add-config in the future. Thanks --Proven On Fri, Feb 17, 2023 at 1:32 PM José Armando García Sancio <jsan...@confluent.io.invalid> wrote: > Hi Proven, > > Thanks for the changes to KIP-900. It looks good to me in general. > Here are some suggestions and questions. > > 1. In the KIP you give the following example: > --add-scram SCRAM-SHA-256=[user=alice,password=alice-secret] > > Is "SCRAM-" required as a prefix? The flag already has the suffix > "-scram". Can the value to the flag be > SHA-256=[user=alice,password=alice-secret]? > > 2. Should the CLI document all possible values for the --add-scram? Is > SCRAM-SHA-256 the only supported algorithm? > > 3. Should the short version of the flag --add-scram be -s? I suspect > that in the future we may want to add more options like --add-acl and > --add-config. > > Thanks! > -- > -José >