Thanks for your feedback Luke. On Thu, Oct 13, 2022 at 11:58 PM Luke Chen <show...@gmail.com> wrote: > The only thing I'd like to point out is the compatibility section. > Since this new config is default to 1 hour, which means if users explicitly > set the config `metadata.log.max.record.bytes.between.snapshots` to a very > large value to avoid snapshot creation, after upgraded, the snapshots will > be created every hour. I think this behavior change should be explicitly > written in compatibility section. WDYT?
I added the following sentence to the compatibility section. "If the user wants to keep the behavior before this KIP was implemented, they would need to disable time based snapshots by setting metadata.log.max.snapshot.interval.ms to zero (0)." KIP-778 introduced snapshot generation when the feature level changes so it would be difficult for users to disable snapshot altogether. -- -José
