Thanks for the KIP Jose! Adding this ability makes sense to me. Just a few quick wonderments: 1. Do we need this value to be of the order of `ms`. Is it better off being tunable to a minute granularity? 2. Somewhat related to 1 - Do we need to make any tweaks to the way we cleanup the metadata directory (time/size based cleanup)? My concern is if the metadata-dir cleanup will trigger fast enough in all cases today. e.g. If I were to configure the time-based snapshotting to something like every 10 seconds, with enough load of course, will I end up flooding the disk.?
On Wed, Oct 12, 2022 at 1:28 AM David Jacot <dja...@confluent.io.invalid> wrote: > Hi José, > > Thanks for the KIP. That makes total sense. On nit, I would name the > new property `metadata.log.snapshot.interval.ms` as `between` is > implied by the `interval`. > > Best, > David > > On Tue, Oct 11, 2022 at 9:16 PM José Armando García Sancio > <jsan...@confluent.io.invalid> wrote: > > > > Hey all, > > > > I am interested in allowing brokers and controllers in KRaft to > > generate snapshots for the cluster metadata partition on a timely > > basis. This would better allow Kafka users to use cluster metadata > > snapshots as a solution for backing up the cluster's metadata. > > > > Let's use this thread to discuss KIP-876: > > https://cwiki.apache.org/confluence/x/MY3GDQ > > > > Thanks! > > -- > > -José > -- - Niket
