Thanks for the KIP! I'm 100% on board with this (obviously :P) and the KIP itself looks good to me overall. Just one clarification I think you should make:
In the *Public Interfaces* section you say "It won't affect the current consumers" -- this is only true if those current consumers have explicitly set the* partition.assignment.strategy *config on their clients. If they've been relying on the default thus far, they will need to either follow the safe upgrade path as described in KIP-429 or else set the *partition.assignment.strategy* config to one of the non- cooperative assignors during the rolling upgrade if they wish to remain on EAGER and/or perform the upgrade in just a single rolling bounce. On that note: We have some thoughts for improving the upgrade experience to actually reduce the safe upgrade path to just a single rolling bounce. This is still in progress and we need to work out all the kinks so I wouldn't commit to a single rolling bounce upgrade as part of this KIP, but it's worth noting that by 3.0 we may be in an even better position with regards to this assignor. The ticket is https://issues.apache.org/jira/browse/KAFKA-12477 Cheers, Sophie On Fri, Mar 26, 2021 at 1:59 AM Sagar <sagarmeansoc...@gmail.com> wrote: > Thank you ! > > Sagar. > > On Fri, 26 Mar 2021 at 2:21 PM, Luke Chen <show...@gmail.com> wrote: > > > Hi Sagar, > > No problem. I changed my KIP to KIP-726, and also added your KIP into the > > KIP list table. > > > > I'll send another discussion mail later for KIP-726. > > > > Thanks > > Luke > > > > On Fri, Mar 26, 2021 at 4:41 PM Sagar <sagarmeansoc...@gmail.com> wrote: > > > > > Hey Luke, > > > > > > There's a conflict in the KIP numbers. I have also used 725 for the > KiP I > > > had written last week; > > > > > > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=177047930 > > > . > > > I had incremented the number while creating this but forgot to add it > > here. > > > > > > Do you want me to change the KIP number or would you it? > > > > > > Thanks! > > > Sagar. > > > > > > On Fri, Mar 26, 2021 at 12:53 PM Luke Chen <show...@gmail.com> wrote: > > > > > > > Hi everyone, > > > > > > > > I'd like to discuss the following proposal to make the > > > > CooperativeStickyAssignor as the default assignor. > > > > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-725%3A+Make+the+CooperativeStickyAssignor+as+the+default+assignor > > > > > > > > Any comments are welcomed. > > > > > > > > Thank you. > > > > Luke > > > > > > > > > >
