On Tue, Aug 11, 2020, at 11:30, Ismael Juma wrote: > Thanks for the KIP, +1 (binding). A couple of comments: > > 1. We have "quorum.voters=1@kafka-1:9092, 2@kafka-2:9092, > 3@kafka-3:9092". Could > this be a bit confusing given that the authority part of a url is defined > as "authority = [userinfo@]host[:port]"? >
Hmm... I don't think there is much chance for confusion. The authority field in URLs is kind of obscure at this point. People used to do stuff like http://myuser:mypassw...@example.com, but I'm not sure most users are even aware that this feature used to exist these days. You could also argue that the voter identity is kind of like the an authority, conceptually. To the extent that it even makes sense to reuse URL concepts for something that isn't a URL, this seems reasonble. Separately, I would argue that we should not re-use the URI or URL classes to parse these strings. We made the mistake of parsing filenames as URLs in Hadoop (and in HDFS) and it created lots of artificial difficulties. I think filenames with a colon still don't work to this day, and filenames with a pound sign are treated inconsistently. Sometimes it's best to just parse a string the way you want to parse it for your particular use-case, and not pull in a large library. > > 2. With regards to the Quorum State file, do we have anything that helps us > detect corruption? > Good question, but it's probably better to have a separate KIP about adding checksums to some of our small text files, since this issue seems to exist for many of them. best, Colin > > Ismael > > > On Mon, Aug 3, 2020 at 11:03 AM Jason Gustafson <ja...@confluent.io> wrote: > > > Hi All, I'd like to start a vote on this proposal: > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-595%3A+A+Raft+Protocol+for+the+Metadata+Quorum > > . > > The discussion has been active for a bit more than 3 months and I think the > > main points have been addressed. We have also moved some of the pieces into > > follow-up proposals, such as KIP-630. > > > > Please keep in mind that the details are bound to change as all of > > the pieces start coming together. As usual, we will keep this thread > > notified of such changes. > > > > For me personally, this is super exciting since we have been thinking about > > this work ever since I started working on Kafka! I am +1 of course. > > > > Best, > > Jason > > >
