Hi Daniel, I was not aware of that PR. At minimum, I would add `--bootstrap-server` to the list in the KIP for completeness. Regarding the implementation, I would leave a comment in that PR asking if they plan to continue it. If not, we could do it as part of your PR directly.
Cheers, David On Mon, Aug 10, 2020 at 10:49 AM Dániel Urbán <urb.dani...@gmail.com> wrote: > Hi everyone, > > Just a reminder, please vote if you are interested in this KIP being > implemented. > > Thanks, > Daniel > > Dániel Urbán <urb.dani...@gmail.com> ezt írta (időpont: 2020. júl. 31., P, > 9:01): > > > Hi David, > > > > There is another PR linked on KAFKA-8507, which is still open: > > https://github.com/apache/kafka/pull/8123 > > Wasn't sure if it will go in, and wanted to avoid conflicts. Do you think > > I should do the switch to '--bootstrap-server' anyway? > > > > Thanks, > > Daniel > > > > David Jacot <dja...@confluent.io> ezt írta (időpont: 2020. júl. 30., Cs, > > 17:52): > > > >> Hi Daniel, > >> > >> Thanks for the KIP. > >> > >> It seems that we have forgotten to include this tool in KIP-499. > >> KAFKA-8507 > >> is resolved > >> by this tool still uses the deprecated "--broker-list". I suggest to > >> include "--bootstrap-server" > >> in your public interfaces as well and fix this omission during the > >> implementation. > >> > >> +1 (non-binding) > >> > >> Thanks, > >> David > >> > >> On Thu, Jul 30, 2020 at 1:52 PM Kamal Chandraprakash < > >> kamal.chandraprak...@gmail.com> wrote: > >> > >> > +1 (non-binding), thanks for the KIP! > >> > > >> > On Thu, Jul 30, 2020 at 3:31 PM Manikumar <manikumar.re...@gmail.com> > >> > wrote: > >> > > >> > > +1 (binding) > >> > > > >> > > Thanks for the KIP! > >> > > > >> > > > >> > > > >> > > On Thu, Jul 30, 2020 at 3:07 PM Dániel Urbán <urb.dani...@gmail.com > > > >> > > wrote: > >> > > > >> > > > Hi everyone, > >> > > > > >> > > > If you are interested in this KIP, please do not forget to vote. > >> > > > > >> > > > Thanks, > >> > > > Daniel > >> > > > > >> > > > Viktor Somogyi-Vass <viktorsomo...@gmail.com> ezt írta (időpont: > >> 2020. > >> > > > júl. > >> > > > 28., K, 16:06): > >> > > > > >> > > > > +1 from me (non-binding), thanks for the KIP. > >> > > > > > >> > > > > On Mon, Jul 27, 2020 at 10:02 AM Dániel Urbán < > >> urb.dani...@gmail.com > >> > > > >> > > > > wrote: > >> > > > > > >> > > > > > Hello everyone, > >> > > > > > > >> > > > > > I'd like to start a vote on KIP-635. The KIP enhances the > >> > > > GetOffsetShell > >> > > > > > tool by enabling querying multiple topic-partitions, adding > new > >> > > > filtering > >> > > > > > options, and adding a config override option. > >> > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > >> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-635%3A+GetOffsetShell%3A+support+for+multiple+topics+and+consumer+configuration+override > >> > > > > > > >> > > > > > The original discussion thread was named "[DISCUSS] KIP-308: > >> > > > > > GetOffsetShell: new KafkaConsumer API, support for multiple > >> topics, > >> > > > > > minimize the number of requests to server". The id had to be > >> > changed > >> > > as > >> > > > > > there was a collision, and the KIP also had to be renamed, as > >> some > >> > of > >> > > > its > >> > > > > > motivations were outdated. > >> > > > > > > >> > > > > > Thanks, > >> > > > > > Daniel > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > >> > > >
